Feature/preimage store reprise#9553
Closed
garyschulte wants to merge 9 commits intobesu-eth:mainfrom
Closed
Conversation
garyschulte
added
the
DO NOT MERGE
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
…taStorageOptions.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/preimage-store
branch
from
287082d to
4b1cfa6
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
Contributor
Author
|
rebasing very likely broke in-memory preimage storage modes. todo: fix in-memory limited, in-memory unbounded preimage store |
|
This pr is stale because it has been open for 30 days with no activity. |
Contributor
|
@garyschulte are you still working on this one? |
Contributor
Author
|
Not really. It will eventually be necessary for state migration, but not soon. |
|
This pr is stale because it has been open for 30 days with no activity. |
|
This pr was closed because it has been inactive for 14 days since being marked as stale. |
15 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
PR to include an preimage storage. This PR is a reprise of 7800. Do not merge
Highlights include:
cli feature param
import/export preimage storage subcommands
forest persisted or in-memory preimages store
bonsai persisted, in-memory limited, in-memory unbounded preimage store
refactoring, removing of reference test specific behavior
incorporation into worldstatekeyvaluestorage classes
✅ reference tests passing
Fixed Issue(s)
fixes #7796
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests